feat: upgrade to React Router 6 #1304
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting
| mapRef.current.remove(); | ||
| mapRef.current = null; | ||
| } | ||
| }; | ||
| }, [navigate, panOnClick, syncUI]); |
There was a problem hiding this comment.
The useEffect that instantiates the MapLibre map depends on syncUI, but syncUI itself captures overlay and the current photo identifier. Every time the user toggles overlays or opens a different photo, this effect runs again, executes its cleanup, and rebuilds the entire map. That wipes the current zoom/center and forces all map tiles and handlers to reload, which did not happen before the router migration. The subsequent effect already updates the overlay and active photo on an existing map, so this initialization effect should run only once (or at most when panOnClick changes).
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Summary
- Stored the latest
syncUIcallback in a ref so map event handlers can use it without forcing reinitialization. frontend/src/screens/App/screens/MapPane/components/MainMap/MapLibreMap.tsxL28-L45 - Updated the map initialization effect to call the ref-backed handler and removed the dependency on overlay/photo changes, preventing unnecessary map rebuilds. frontend/src/screens/App/screens/MapPane/components/MainMap/MapLibreMap.tsxL99-L122
Testing
⚠️ npm run lint(fails in husky pre-commit becauselint.shhits a shell syntax error in this environment)
Summary
Testing
https://chatgpt.com/codex/tasks/task_e_68ed64e30a5c832993c373433e9ed684